Re: [PATCH 1/6] lib/cli: Make notmuch_database_open return a status code

Subject: Re: [PATCH 1/6] lib/cli: Make notmuch_database_open return a status code

Date: Mon, 30 Apr 2012 08:39:32 -0300

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: David Bremner

I have two questions, both of which might have been settled previously.

>  
> -    return notmuch;
> +    *database = notmuch;
> +    return status;
>  }

Should we check database is non-NULL here?

> diff --git a/notmuch-count.c b/notmuch-count.c
> index 9c2ad7b..2f98128 100644
> --- a/notmuch-count.c
> +++ b/notmuch-count.c

> +    if (notmuch_database_open (notmuch_config_get_database_path (config),
> +			       NOTMUCH_DATABASE_MODE_READ_ONLY, &notmuch))

Is it OK to rely on NOTMUCH_STATUS_SUCCESS==0 ?

d

• Previous message (by thread): Re: [PATCH v2 1/6] lib/cli: Make notmuch_database_open return a status code

Thread:

• Austin Clements—[PATCH 0/6] Make notmuch_database_{open,create} return status codes [inbox, unread]
  • Austin Clements—[PATCH 1/6] lib/cli: Make notmuch_database_open return a status code [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 1/6] lib/cli: Make notmuch_database_open return a status code [inbox, notmuch::review, unread]
      • Austin Clements—Re: [PATCH 1/6] lib/cli: Make notmuch_database_open return a status code [inbox, unread]
  • Austin Clements—[PATCH 2/6] lib/cli: Make notmuch_database_create return a status code [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—[PATCH 3/6] go: Update Go bindings for new notmuch_database_{open, create} signatures [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—[PATCH 4/6] python: Update Python bindings for new notmuch_database_{open, create} signatures [inbox, notmuch::obsolete, notmuch::patch, notmuch::python, unread]
  • Austin Clements—[PATCH 5/6] ruby: Update Ruby bindings for new notmuch_database_{open, create} signatures [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—[PATCH 6/6] News for changes to notmuch_database_{open,create} [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Justus Winter—Re: [PATCH 0/6] Make notmuch_database_{open, create} return status codes [inbox, unread]
  • Austin Clements—[PATCH v2 0/6] Make notmuch_database_{open, create} return status codes [inbox, unread]
    • Austin Clements—[PATCH v2 1/6] lib/cli: Make notmuch_database_open return a status code [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—Re: [PATCH v2 1/6] lib/cli: Make notmuch_database_open return a status code [inbox, unread]
    • Austin Clements—[PATCH v2 2/6] lib/cli: Make notmuch_database_create return a status code [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—[PATCH v2 3/6] go: Update Go bindings for new notmuch_database_{open, create} signatures [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—[PATCH v2 4/6] python: Update Python bindings for new notmuch_database_{open, create} signatures [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—[PATCH v2 5/6] ruby: Update Ruby bindings for new notmuch_database_{open, create} signatures [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—[PATCH v2 6/6] News for changes to notmuch_database_{open,create} [inbox, notmuch::patch, notmuch::pushed, unread]
    • Tomi Ollila—Re: [PATCH v2 0/6] Make notmuch_database_{open, create} return status codes [inbox, unread]
      • Austin Clements—Re: [PATCH v2 0/6] Make notmuch_database_{open, create} return status codes [inbox, unread]