Quoth Tomi Ollila on May 02 at 10:08 pm: > On Mon, Apr 30 2012, Austin Clements <amdragon@MIT.EDU> wrote: > > > Relative to v1, this makes notmuch_database_open and > > notmuch_database_create gracefully handle a NULL out-argument and adds > > documentation of the possible error return values from these two > > functions. Patches 3 and on have not changed. > > LGTM. > > One question though: > > In bindings/python/notmuch/database.py class Database functions > create() and open() have the following last lines: > > + if status != STATUS.SUCCESS: > + raise NotmuchError(status) > + self._db = db > + return status > > What is the point returning 'status' in the only case the > value is STATUS.SUCCESS -- is some caller interested on this ? This was for consistency with other methods (e.g., begin_atomic also only ever returns STATUS.SUCCESS).