Re: [PATCH 2/9] test: set EMACS_SERVER variable only after dtach(1) was successfully started

Subject: Re: [PATCH 2/9] test: set EMACS_SERVER variable only after dtach(1) was successfully started

Date: Thu, 17 Nov 2011 15:07:59 +0400

To: Jameson Graef Rollins, notmuch@notmuchmail.org

Cc:

From: Dmitry Kurochkin

On Thu, 17 Nov 2011 01:14:13 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Thu, 17 Nov 2011 05:56:19 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Otherwise, we can set the EMACS_SERVER and return with an error.  And
> > subsequent calls to test_emacs would assume that emacs server is running.
> 
> Hey, Dmitry.  Can you explain this a bit more?  I'm not sure I
> understand the case this is protecting against.
> 

We are protectint from the case when dtach is not installed.  Then we
would return from the test_emacs function with an error "dtach ... ||
return".  EMACS_SERVER should not be set in this case.

Regards,
  Dmitry

> jamie.

Thread: