Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

Subject: Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

Date: Thu, 30 Nov 2017 09:19:57 -0500

To: David Bremner, Floris Bruynooghe, Ruben Pollan, notmuch@notmuchmail.org

Cc:

From: Daniel Kahn Gillmor


On Thu 2017-11-30 09:44:19 -0400, David Bremner wrote:
> Floris Bruynooghe <flub@devork.be> writes:
>
>> This also has the binary question problem, is this returned as bytes or
>> as str?  Current Python bindings seem to go for .decode('utf-8',
>> errors='ignore') afaik which is somewhat lossy.
>>
>
> IMHO there's no reason to support non-utf8 properties. We should
> document this restriction now while adoption is relatively light.

Agreed, my reading of the source is that we expect strings for both
property names and property values.  If they're both strings, we should
not support anything other than UTF-8 in either case.

      --dkg
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: