Re: [PATCH v2 05/11] emacs: notmuch-search: add filesize sorting

Subject: Re: [PATCH v2 05/11] emacs: notmuch-search: add filesize sorting

Date: Sat, 10 Jun 2017 21:15:17 -0300

To: Ioan-Adrian Ratiu, notmuch@notmuchmail.org

Cc:

From: David Bremner


Ioan-Adrian Ratiu <adi@adirat.com> writes:

> Besides the previous date-based result orderings (oldest-first and
> newest-first) add two more filesize-based orderings: biggest-first
> smallest-first.
>
> The orderings are interchangeable, you can specify any one as the
> default via notmuch-search-default-sort-order or as the preffered
                                                    spelling ^
> ordering for a saved search (via the :sort-order property).
>
> Signed-off-by: Ioan-Adrian Ratiu <adi@adirat.com>
> ---
>  emacs/notmuch-hello.el |  9 ++++++---
>  emacs/notmuch-lib.el   |  4 +++-
>  emacs/notmuch.el       | 12 ++++++++++--
>  3 files changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 3ba2a16b..51117577 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -95,7 +95,9 @@ searches so they still work in customize."
>  			    (choice :tag " Sort Order"
>  				    (const :tag "Default" nil)
>  				    (const :tag "Oldest-first" oldest-first)
> -				    (const :tag "Newest-first" newest-first)))
> +				    (const :tag "Newest-first" newest-first)
> +				    (const :tag "Biggest-first" biggest-first)
> +				    (const :tag "Smallest-first" smallest-first)))

I agree with Tomi that Largest sounds better than Biggest here.


Thread: