Re: [PATCH 1/3] lib: handle DatabaseModifiedError in _notmuch_message_create

Subject: Re: [PATCH 1/3] lib: handle DatabaseModifiedError in _notmuch_message_create

Date: Thu, 24 Jul 2025 07:50:52 -0300

To: Anton Khirnov, notmuch@notmuchmail.org

Cc:

From: David Bremner


Anton Khirnov <anton@khirnov.net> writes:

> Quoting David Bremner (2025-07-23 13:31:22)
>> Anton Khirnov <anton@khirnov.net> writes:
>> 
>> > diff --git a/test/T641-database-modified-messages.sh b/test/T641-database-modified-messages.sh
>> > +    for (try = 0; try < 2; try++) {
>> > +	for (;
>> > +	     notmuch_messages_valid (messages_ro);
>> > +	     notmuch_messages_move_to_next (messages_ro)) {
>> > +	    notmuch_message_t *message = notmuch_messages_get (messages_ro);
>> > +	}
>> 
>> I'd prefer not to introduce new use of notmuch_messages_valid in the
>> test suite. I think you [1] convinced me not to immediately deprecate
>> notmuch_messages_valid, but it is some small amount of technical debt we
>> can avoid. If you prefer not to do a new version of the patch, I can
>> amend it with s/notmuch_messages_valid/! notmuch_messages_status/
>
> Sure, feel free.

Done, and applied to master.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: