Anton Khirnov <anton@khirnov.net> writes:

> diff --git a/test/T641-database-modified-messages.sh b/test/T641-database-modified-messages.sh
> +    for (try = 0; try < 2; try++) {
> +	for (;
> +	     notmuch_messages_valid (messages_ro);
> +	     notmuch_messages_move_to_next (messages_ro)) {
> +	    notmuch_message_t *message = notmuch_messages_get (messages_ro);
> +	}

I'd prefer not to introduce new use of notmuch_messages_valid in the
test suite. I think you [1] convinced me not to immediately deprecate
notmuch_messages_valid, but it is some small amount of technical debt we
can avoid. If you prefer not to do a new version of the patch, I can
amend it with s/notmuch_messages_valid/! notmuch_messages_status/

By the way, do you plan to update the python bindings to add the new
function/method?  It seems like to really fix the original alot problem
you might need to somehow re-translate this into an exception? There are
also the ruby bindings, but I guess that might be too much to hope for ;).

[1] More precisely looking at the cleanup required in notmuch.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org