Re: [PATCH 1/3] lib: handle DatabaseModifiedError in _notmuch_message_create

Subject: Re: [PATCH 1/3] lib: handle DatabaseModifiedError in _notmuch_message_create

Date: Thu, 24 Jul 2025 11:39:28 +0200

To: notmuch@notmuchmail.org, David Bremner

Cc:

From: Anton Khirnov


Quoting David Bremner (2025-07-23 13:31:22)
> Anton Khirnov <anton@khirnov.net> writes:
> 
> > diff --git a/test/T641-database-modified-messages.sh b/test/T641-database-modified-messages.sh
> > +    for (try = 0; try < 2; try++) {
> > +	for (;
> > +	     notmuch_messages_valid (messages_ro);
> > +	     notmuch_messages_move_to_next (messages_ro)) {
> > +	    notmuch_message_t *message = notmuch_messages_get (messages_ro);
> > +	}
> 
> I'd prefer not to introduce new use of notmuch_messages_valid in the
> test suite. I think you [1] convinced me not to immediately deprecate
> notmuch_messages_valid, but it is some small amount of technical debt we
> can avoid. If you prefer not to do a new version of the patch, I can
> amend it with s/notmuch_messages_valid/! notmuch_messages_status/

Sure, feel free.

> By the way, do you plan to update the python bindings to add the new
> function/method?

Yes, I even did some preliminary work, but wanted to wait until the C
API side was finalized.

> It seems like to really fix the original alot problem you might need
> to somehow re-translate this into an exception?

Yes, that was my thinking as well.

> There are also the ruby bindings, but I guess that might be too much
> to hope for ;).

Yeah sorry, I don't speak Ruby.

Cheers,
-- 
Anton Khirnov
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: