Re: [PATCH 1/2] test: add another known broken test for uncaught DatabaseModifiedError

Subject: Re: [PATCH 1/2] test: add another known broken test for uncaught DatabaseModifiedError

Date: Fri, 04 Jul 2025 07:32:45 -0300

To: Anton Khirnov, notmuch@notmuchmail.org

Cc:

From: David Bremner


Anton Khirnov <anton@khirnov.net> writes:

> This one is raised from _notmuch_message_create().
>
> See also https://github.com/pazz/alot/issues/1460#issuecomment-2994101019
> ---
>  test/T641-database-modified-messages.sh | 82 +++++++++++++++++++++++++
>  1 file changed, 82 insertions(+)
>  create mode 100755 test/T641-database-modified-messages.sh
>
[snip]
> +test_begin_subtest "catching DatabaseModifiedError in _notmuch_message_create"
> +
misses test_subtest_known_broken here
> +test_C ${MAIL_DIR} <<EOF

> +#include <notmuch-test.h>
> +    assert(ro_db);
> +
> +    query_ro = notmuch_query_create(ro_db, "");

I understand it's a pain in tests, but try to be consistent with ' '
before function and macro arguments. One trick I have used is to copy
the code out of the test into a .c file and format it there.

Other than those tweaks I have no objection to adding this test.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: