Re: [PATCH v2 0/4] Add refresh all buffers functionality

Subject: Re: [PATCH v2 0/4] Add refresh all buffers functionality

Date: Thu, 06 Oct 2016 09:59:35 -0400

To: Tomi Ollila, Mark Walters, Ioan-Adrian Ratiu, David Bremner, notmuch@notmuchmail.org

Cc:

From: Daniel Kahn Gillmor


<silly vocab nitpicking>

On Sun 2016-09-25 03:32:08 -0400, Tomi Ollila wrote:
> 2) then, minor commit message related comment: if there is going to be v3,
> in id:20160924200735.25425-2-adi@adirat.com adi mentioned 'next patches'
> -- those are not patches (anymore) when commits are made, so it would be
> better to reword that sentence. If anythine else doesn't come up, simplest
> thing is to change the word to 'commits'. As said, this is minor thing,
> and we have worse things in commit messages; if there is no need to send
> v3, or the message change is forgotten then it may go in as it is now...

Before these things are accepted into whatever you consider the
canonical git repo to be, while they're still patches floating around in
our various mailboxes, they aren't really "commits" either.  I'd use
"changesets" as the generic term.

</silly vocab nitpicking>

        --dkg
signature.asc (application/pgp-signature)

Thread: