Re: [PATCH] test: add tests wrt ignoring user-specified files and directories

Subject:Re: [PATCH] test: add tests wrt ignoring user-specified files and directories

Date:Fri, 03 Feb 2012 17:39:07 -0500

To:Tomi Ollila ,Pieter Praet ,David Edmondson ,David Bremner

Cc:Notmuch Mail

From:Austin Clements


On Fri, 03 Feb 2012 14:14:21 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Wed,  1 Feb 2012 15:12:53 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Files and directories which are specified in 'new.ignore' in the
> > config file shouldn't be indexed nor reported by `notmuch new'.
> > 
> > ---
> 
> +1 
> 
> tested file order with:
> 
> $ touch ~/mail/mails/a
> $ touch ~/mail/mails/d
> $ touch ~/mail/mails/o
> $ touch ~/mail/mails/p
> $ touch ~/mail/mails/g
> $ touch ~/mail/mails/z
> $ touch ~/mail/mails/u
> $ touch ~/mail/mails/l     
> 
> $ notmuch new
> Note: Ignoring non-mail file: /home/too/mail/mails/a
> Note: Ignoring non-mail file: /home/too/mail/mails/d
> Note: Ignoring non-mail file: /home/too/mail/mails/g
> Note: Ignoring non-mail file: /home/too/mail/mails/l
> Note: Ignoring non-mail file: /home/too/mail/mails/o
> Note: Ignoring non-mail file: /home/too/mail/mails/p
> Note: Ignoring non-mail file: /home/too/mail/mails/u
> Note: Ignoring non-mail file: /home/too/mail/mails/z
> 
> So we can be pretty confident that files are printed
> in ASCII order.

This is true if the containing directory has been scanned by notmuch
before (which is sufficiently true in this patch).  If the containing
directory is new, they're in inode order (so no guarantees).

Thread: