Re: [PATCH] moved _notmuch_(get|set)_list () functions earlyer in the file

Subject: Re: [PATCH] moved _notmuch_(get|set)_list () functions earlyer in the file

Date: Fri, 27 Jan 2012 17:15:20 -0500

To: Tomi Ollila

Cc: notmuch@notmuchmail.org

From: Austin Clements

Quoth Tomi Ollila on Jan 27 at 12:59 pm:
> Moved static functions _notmuch_get_list () and _notmuch_set_list ()
> closer to the beginning of file so that their definition is known
> (without adding forward declarations) in further work.
> 
> No functional changes.

This patch LGTM.  This is where these functions should live
regardless.

• Previous message (by thread): Re: [PATCH] test: another test wrt ignoring user-specified files and directories

Thread:

• tomi.ollila@iki.fi—[PATCH 0/3] Configuration file option to exclude files/directories [inbox, notmuch::core, notmuch::feature, unread]
  • tomi.ollila@iki.fi—[PATCH 1/3] added function notmuch_talloc_g_key_file_get_string_list() [inbox, notmuch::core, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  • tomi.ollila@iki.fi—[PATCH 2/3] Made notmuch_config_get_new_tags() use notmuch_talloc_g_key_file_get_string_list(). [inbox, notmuch::core, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  • tomi.ollila@iki.fi—[PATCH 3/3] added support for user-specified directories to exclude [inbox, notmuch::core, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—Re: [PATCH 0/3] Configuration file option to exclude files/directories [inbox, unread]
    • Tom Prince—Re: [PATCH 0/3] Configuration file option to exclude files/directories [inbox, unread]
    • Tomi Ollila—Re: [PATCH 0/3] Configuration file option to exclude files/directories [inbox, unread]
      • Pieter Praet—Re: [PATCH 0/3] Configuration file option to exclude files/directories [inbox, unread]
        • Tomi Ollila—[PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list () up in file [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Tomi Ollila—[PATCH 2/2] added support for user-specified directories to exclude [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Jani Nikula—Re: [PATCH 2/2] added support for user-specified directories to exclude [inbox, notmuch::review, unread]
              • Tomi Ollila—Re: [PATCH 2/2] added support for user-specified directories to exclude [inbox, unread]
                • Austin Clements—Re: [PATCH 2/2] added support for user-specified directories to exclude [inbox, notmuch::review, unread]
                • Fabio Zanini—Re: [PATCH 2/2] added support for user-specified directories to exclude [inbox, unread]
            • Austin Clements—Re: [PATCH 2/2] added support for user-specified directories to exclude [inbox, notmuch::review, unread]
          • Jani Nikula—Re: [PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list () up in file [inbox, notmuch::review, unread]
            • Tomi Ollila—Re: [PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list () up in file [inbox, unread]
              • Ethan Glasser-Camp—Re: [PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list () up in file [inbox, unread]
                • Tomi Ollila—[PATCH] moved _config_(get|set)_list () functions earlyer in the file [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
                  • Austin Clements—Re: [PATCH] moved _config_(get|set)_list () functions earlyer in the file [inbox, notmuch::review, unread]
                  • David Bremner—Re: [PATCH] moved _config_(get|set)_list () functions earlyer in the file [inbox, unread]
            • Tomi Ollila—[PATCH] moved _notmuch_(get|set)_list () functions earlyer in the file [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
              • Austin Clements—Re: [PATCH] moved _notmuch_(get|set)_list () functions earlyer in the file [inbox, notmuch::review, unread]
      • David Edmondson—Re: [PATCH 0/3] Configuration file option to exclude files/directories [inbox, notmuch::review, signed, unread]
        • Pieter Praet—[PATCH] test: add tests wrt ignoring user-specified files and directories [inbox, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
          • Tomi Ollila—Re: [PATCH] test: add tests wrt ignoring user-specified files and directories [inbox, notmuch::review, unread]
            • Austin Clements—Re: [PATCH] test: add tests wrt ignoring user-specified files and directories [inbox, notmuch::review, unread]
          • Austin Clements—Re: [PATCH] test: add tests wrt ignoring user-specified files and directories [inbox, notmuch::review, unread]
            • Pieter Praet—Re: [PATCH] test: add tests wrt ignoring user-specified files and directories [inbox, unread]
  • Tomi Ollila—[PATCH] added support for user-specified files & directories to ignore [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Pieter Praet—Re: [PATCH] added support for user-specified files & directories to ignore [inbox, notmuch::review, unread]
    • Jani Nikula—Re: [PATCH] added support for user-specified files & directories to ignore [inbox, notmuch::review, unread]
    • Austin Clements—Re: [PATCH] added support for user-specified files & directories to ignore [inbox, notmuch::review, unread]
  • Tomi Ollila—[PATCH v6 1/3] test: add tests wrt ignoring user-specified files and directories [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—[PATCH v6 2/3] add support for user-specified files & directories to ignore [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Tomi Ollila—Re: [PATCH v6 2/3] add support for user-specified files & directories to ignore [inbox, unread]
    • Tomi Ollila—[PATCH v6 3/3] NEWS: add news section for new.ignore [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Austin Clements—Re: [PATCH v6 3/3] NEWS: add news section for new.ignore [inbox, notmuch::review, unread]
    • Tomi Ollila—Re: [PATCH v6 1/3] test: add tests wrt ignoring user-specified files and directories [inbox, unread]
      • Austin Clements—Re: [PATCH v6 1/3] test: add tests wrt ignoring user-specified files and directories [inbox, notmuch::review, unread]
    • Austin Clements—Re: [PATCH v6 1/3] test: add tests wrt ignoring user-specified files and directories [inbox, notmuch::review, unread]
  • Tomi Ollila—[PATCH v7 0/3] NEWS and test comment adjustments [inbox, unread]
    • Tomi Ollila—[PATCH v7 1/3] test: add tests wrt ignoring user-specified files and directories [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
    • Tomi Ollila—[PATCH v7 2/3] add support for user-specified files & directories to ignore [inbox, notmuch::patch, notmuch::pushed, unread]
    • Tomi Ollila—[PATCH v7 3/3] NEWS: add news section for new.ignore [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v7 0/3] NEWS and test comment adjustments [inbox, unread]
      • Pieter Praet—Re: [PATCH v7 0/3] NEWS and test comment adjustments [inbox, unread]
        • Pieter Praet—[PATCH 1/6] cli: update 'new.ignore' config file comment wrt file/directory matching [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
          • David Bremner—Re: [PATCH 1/6] cli: update 'new.ignore' config file comment wrt file/directory matching [inbox, unread]
        • Pieter Praet—[PATCH 2/6] NEWS: sync 'new.ignore' entry with its comment in notmuch-config.c [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
          • David Bremner—Re: [PATCH 2/6] NEWS: sync 'new.ignore' entry with its comment in notmuch-config.c [inbox, unread]
        • Pieter Praet—[PATCH 3/6] cli: add '--debug' option to 'notmuch new' [inbox, notmuch::feature, notmuch::patch, notmuch::pushed, unread]
        • Pieter Praet—[PATCH 4/6] cli: notmuch new: optionally output debug information when ignoring files/directories [inbox, notmuch::patch, notmuch::pushed, unread]
        • Pieter Praet—[PATCH 5/6] test-lib.sh: pass 'NOTMUCH_NEW's args down to 'notmuch new' [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
        • Pieter Praet—[PATCH 6/6] test: another test wrt ignoring user-specified files and directories [inbox, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
          • David Bremner—Re: [PATCH 6/6] test: another test wrt ignoring user-specified files and directories [inbox, unread]
            • Ethan Glasser-Camp—[PATCH] test: another test wrt ignoring user-specified files and directories [inbox, notmuch::needs-review, notmuch::patch, notmuch::pushed, unread]
              • David Bremner—Re: [PATCH] test: another test wrt ignoring user-specified files and directories [inbox, unread]