On Tue, 17 Jan 2012 11:50:53 +0100, Thomas Jost <schnouki@schnouki.net> wrote: > There are lots of API changes in gmime 2.6 crypto handling. By adding > preprocessor directives, it is however possible to add gmime 2.6 compatibility > while preserving compatibility with gmime 2.4 too. > > This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info". > > This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31, the > crypto tests all work fine (as expected). With gmime 2.6.4, one crypto test > fails (signature verification with signer key unavailable) but this will be hard > to fix since the new API does not report the reason why a signature verification > fails (other than the human-readable error message). > --- LGTM. Some whitespace things but most of those were there already; I'd have one uncrustify round to be applied to the source and after that be more strict about those... actually gmime 2.4 has GMIME_CHECK_VERSION defined as g_mime_check_version (major, minor, micro) so the comment about it is not entirely accurate (it is unusable in our context, though) Tomi