Re: [PATCH v4 1/3] show: don't use hex literals in JSON output

Subject: Re: [PATCH v4 1/3] show: don't use hex literals in JSON output

Date: Fri, 20 Jan 2012 09:20:52 -0400

To: Thomas Jost, notmuch@notmuchmail.org

Cc:

From: David Bremner


On Fri, 20 Jan 2012 13:33:58 +0100, Thomas Jost <schnouki@schnouki.net> wrote:

> The most common gmime error codes are 1 (expired signature), 2 (no
> public key), 4 (expired key) and 8 (revoked key). The other possible
> value is 16 (unsupported algorithm) but obviously it is much more rare.
> If this happens, the current code will add '"errors": 10' (hex for
> 16...). This is valid JSON (it looks like a decimal number) but it is
> incorrect (should be 16, not 10).

Maybe something like this for the commit message?

d

Thread: