Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

Subject: Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

Date: Tue, 27 Mar 2012 09:19:34 +0300

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Tue, Mar 27 2012, Austin Clements <amdragon@MIT.EDU> wrote:

> Previously, this function took an argument called "message-id", even
> though it was a general query, rather than a message ID.  This changes
> it to "query".
> ---

+1 

Tomi


>  emacs/notmuch-lib.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 2e367b5..4b17ecc 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -219,13 +219,13 @@ the given type."
>  
>  ;; Helper for parts which are generally not included in the default
>  ;; JSON output.
> -(defun notmuch-get-bodypart-internal (message-id part-number process-crypto)
> +(defun notmuch-get-bodypart-internal (query part-number process-crypto)
>    (let ((args '("show" "--format=raw"))
>  	(part-arg (format "--part=%s" part-number)))
>      (setq args (append args (list part-arg)))
>      (if process-crypto
>  	(setq args (append args '("--decrypt"))))
> -    (setq args (append args (list message-id)))
> +    (setq args (append args (list query)))
>      (with-temp-buffer
>        (let ((coding-system-for-read 'no-conversion))
>  	(progn
> -- 
> 1.7.7.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: