Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

Subject: Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

Date: Wed, 28 Mar 2012 19:23:56 -0700

To: Austin Clements

Cc: notmuch@notmuchmail.org

From: Jameson Graef Rollins

On Wed, Mar 28 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> All true.  But there's a difference between a message ID and an id:
> query and the argument name threw me off for a moment when I was
> writing the id: query quoting patch.  It could be `id-query', I
> suppose, but really it could be any query that matches a single
> message.

Fair enough.  And it's good to have things named correctly and
consistently, so LGTM.

jamie.

• Previous message (by thread): Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

Thread:

• Austin Clements—[PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  • Tomi Ollila—Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal [inbox, notmuch::review, unread]
  • Jameson Graef Rollins—Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal [inbox, signed, unread]
    • Austin Clements—Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal [inbox, unread]
      • Jameson Graef Rollins—Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal [inbox, notmuch::review, signed, unread]
  • David Bremner—Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal [inbox, unread]
  • David Bremner—Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal [inbox, unread]