Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

Subject: Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

Date: Wed, 28 Mar 2012 18:46:02 -0700

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins

On Mon, Mar 26 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> Previously, this function took an argument called "message-id", even
> though it was a general query, rather than a message ID.  This changes
> it to "query".

I'm sure the argument was named such because: the function is retrieving
a message part so the query has to match just a single message, and it's
only ever given a message id by anything that calls it.  And it's an
unexposed internal function.  All of this to say that I think it doesn't
really matter that the argument was named as it was.

jamie.
part-000.sig (application/pgp-signature)

Thread: