Re: [PATCH 2/4] dirent->d_type not available on Soalris

Subject: Re: [PATCH 2/4] dirent->d_type not available on Soalris

Date: Wed, 11 Apr 2012 21:57:45 +0300

To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org

Cc: Vladimir Marek

From: Tomi Ollila


On Mon, Apr 09 2012, Vladimir.Marek@oracle.com wrote:

> From: Vladimir Marek <vlmarek@volny.cz>
>
> The inspiration was taken from similar issue in mutt:
> http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html
>
> Signed-off-by: Vladimir Marek <vlmarek@volny.cz>
> ---

Code looks pretty good, but 2 issues

1) Commit message should contain more verbose information what and 
   why something was done.

2) Does these #ifdefs break code indenters such as uncrustify(1),
   indent(1) and emacs(1) indent functionality.
   (That used to happen but maybe these indenters are smarted today.

Tomi

>  notmuch-new.c |   28 ++++++++++++++++++++++++++++
>  1 files changed, 28 insertions(+), 0 deletions(-)

Thread: