Re: [PATCH 4/4] Explicitly type void* pointers

Subject: Re: [PATCH 4/4] Explicitly type void* pointers

Date: Tue, 10 Apr 2012 08:53:24 +0200

To: Jani Nikula

Cc: Notmuch Mail

From: Vladimir Marek


[...]

> I'm throwing in a third alternative below. Does it work for you? I think
> it's both prettier and uglier than the above at the same time! ;)
> 
> A middle ground would be to change the callers to use
> "notmuch_talloc_steal", and just #define notmuch_talloc_steal
> talloc_steal if __GNUC__ >= 3.
> 
> One could argue upstream talloc should have this, but OTOH it's a C
> library.

That's a nice trick, and it indeed works for me. And I like it more than
what I suggested.

Thank you
-- 
	Vlad

Thread: