Re: [PATCH v2] configure: check for pytest with python -m pytest

Subject: Re: [PATCH v2] configure: check for pytest with python -m pytest

Date: Fri, 07 Aug 2020 20:12:58 +0300

To: Đoàn Trần Công Danh, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Mon, Aug 03 2020, Đoàn Trần Công Danh wrote:

> On different distro, pytest is suffixed with different patterns.
>
> On the other hand, `python3-pytest' could be invoked correctly,
> via `python3 -m pytest', the latter is used by our tests, now.
>
> Switch to `$python -m pytest` to fix address all incompatible naming.
>
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>

THis series looks good to me on my terminal, but does not apply 
to my tree (HEAD commit: 0e4695ab (origin/master) test: regression tests for n_indexopts_{get,set}_decrypt_policy)

Tomi

> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index db3538b3..f7c1c095 100755
> --- a/configure
> +++ b/configure
> @@ -814,7 +814,7 @@ if [ $have_python3 -eq 1 ]; then
>      printf "Checking for python3 pytest (>= 3.0)... "
>      conf=$(mktemp)
>      printf "[pytest]\nminversion=3.0\n" > $conf
> -    if pytest-3 -c $conf --version >/dev/null 2>&1; then
> +    if "$python" -m pytest -c $conf --version >/dev/null 2>&1; then
>          printf "Yes.\n"
>          have_python3_pytest=1
>      else
> -- 
> 2.28.0.163.g6104cc2f0b
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: