On 2020-07-29 21:05:37-0300, David Bremner <david@tethera.net> wrote:
> Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> 
> > On 2020-07-28 08:17:49-0300, David Bremner <david@tethera.net> wrote:
> >> Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> >> 
> >> > Starting from xapian 1.3.5, xapian switched default backend to glass.
> >> >
> >> > From 00cdfe10 (build: drop support for xapian versions less than 1.4,
> >> > 2020-04-22), we only support xapian 1.4.0+. Effectively, we don't need
> >> > to check for default xapian backend anymore.
> >> >
> >> > Let's drop it.
> >> 
> >> This is not wrong, but I wonder if we will need to put it all back in a
> >> slightly modified form when Xapian 1.6 releases with a new default
> >> backend.  I guess we can start by reverting this patch if that happens?
> >
> > I have a quick skim over current codebase,
> > if I have not missed anything,
> > this check is only applicable for testing.
> >
> > I think a future-proof move would be moving
> > this check to a runtime check in "make test".
> >
> > What do you think?
> 
> I sent a couple of patches removing all use from the test suite, so you
> could respin your series with just the configure modifications. Or feel
> free to incorporate my patches into your series, whatever is most
> convenient. It's quite possible there are shell script related
> improvements for my patches, so you might want to wait a couple of days.

I'll wait until they got merged down to master before reroll my changes
to avoid further conflicts.

-- 
Danh
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org