Re: [PATCH] T355: specify hash algorithm explicitly

Subject: Re: [PATCH] T355: specify hash algorithm explicitly

Date: Mon, 27 Jul 2020 20:40:39 +0300

To: Đoàn Trần Công Danh, notmuch@notmuchmail.org

Cc: Đoàn Trần Công Danh

From: Tomi Ollila


On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote:

> On some systems (notably, the one shipped with LibreSSL),
> default fingerprint digest algorithm is SHA256.
>
> On other systems, users can change default digest algorithm by changing
> default_md in /etc/ssl/default_md.
>
> Let's ask openssl to provide us specific algorithm to make the test
> more deterministic.
>
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> ---
>  test/T355-smime.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/T355-smime.sh b/test/T355-smime.sh
> index f8cec62c..8b2b52be 100755
> --- a/test/T355-smime.sh
> +++ b/test/T355-smime.sh
> @@ -6,7 +6,7 @@ test_description='S/MIME signature verification and decryption'
>  test_require_external_prereq openssl
>  test_require_external_prereq gpgsm
>  
> -FINGERPRINT=$(openssl x509 -fingerprint -in "$NOTMUCH_SRCDIR/test/smime/key+cert.pem" -noout | sed -e 's/^.*=//' -e s/://g)
> +FINGERPRINT=$(openssl x509 -sha1 -fingerprint -in "$NOTMUCH_SRCDIR/test/smime/key+cert.pem" -noout | sed -e 's/^.*=//' -e s/://g)

Looks good to me -- provided that this `-sha1` option is known by all
openssl(1) commmands we expect to be supported...

Tomi


>  
>  add_gpgsm_home
>  
> -- 
> 2.28.0.rc2.21.g5c06d60fc5
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: