On Thu, Apr 30 2020, Daniel Kahn Gillmor wrote: > This series applies after the "Add tests for S/MIME PKCS#7 messages" > series, which was introduced in > id:20200428185723.660184-1-dkg@fifthhorseman.net > > With this series applied, notmuch handles standard PKCS#7 S/MIME > messages (using GnuPG's gpgsm as a backend, as mediated by GMime's use > of GPGME) as well as it handles PGP/MIME messages. > > In addition to showing and replying to these messages, the series > covers indexing the cleartext of encrypted messages, and understanding > protected headers. I did not see anything suspicious in code, but I got these test failures: in ubuntu 19.10 native environment, and in debian 10 (podman) container running in fedora 31 system T355-smime: Testing S/MIME signature verification and decryption FAIL Verify signature on PKCS#7 SignedData message crypto: value not equal: data[0][0][0]["crypto"]["signed"]["status"][0] = {'status': 'good', 'fingerprint': '702BA4B157F1E2B7D16B0C6A5FFC8A7DE2057DEB', 'created': 1574813489, 'expires': 2611032858} != {'created': 1574813489, 'expires': 2611032858, 'fingerprint': '702BA4B157F1E2B7D16B0C6A5FFC8A7DE2057DEB', 'userid': 'CN=Alice Lovelace', 'status': 'good'} T356-protected-headers: Testing Message decryption with protected headers FAIL verify signed PKCS#7 subject (multipart-signed) sig_uid: object not found: data[0][0][0]["crypto"]["signed"]["status"][0]["userid"] FAIL verify signed PKCS#7 subject (onepart-signed) sig_uid: object not found: data[0][0][0]["crypto"]["signed"]["status"][0]["userid"] FAIL confirm signed and encrypted PKCS#7 subject (sign+enc) sig_uid: object not found: data[0][0][0]["crypto"]["signed"]["status"][0]["userid"] FAIL confirm signed and encrypted PKCS#7 subject (sign+enc+legacy-disp) sig_uid: object not found: data[0][0][0]["crypto"]["signed"]["status"][0]["userid"] > > --dkg Tomi _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch