Re: [PATCH 1/2 v2] test-lib: mark function variables as local

Subject: Re: [PATCH 1/2 v2] test-lib: mark function variables as local

Date: Sun, 10 May 2020 16:02:22 -0300

To: Daniel Kahn Gillmor, Notmuch Mail

Cc: Tomi Ollila

From: David Bremner

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

>
> yes, that's right.  For certain GMime versions, there's an intermediate
> breakage.  I think you're saying you want me to rerun the series, with
> these things split out so that even on systems with older GMime, tests
> pass at every commit.  I'll try to get that done today.

Sounds perfect.

d
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: [PATCH 2/2 v3] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

Thread:

• Daniel Kahn Gillmor—Handle PKCS#7 S/MIME messages [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 1/9] lib: index PKCS7 SignedData parts [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 2/9] smime: Identify encrypted S/MIME parts during indexing [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 3/9] cli: include wrapped part of PKCS#7 SignedData in the MIME tree [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 4/9] cli/show: If a leaf part has children, show them instead of omitting [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 5/9] cli/reply: Ignore PKCS#7 wrapper parts when replying [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 6/9] crypto: Make _notmuch_crypto_decrypt take a GMimeObject [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 7/9] crypto: handle PKCS#7 envelopedData in _notmuch_crypto_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 8/9] smime: Pass PKCS#7 envelopedData to node_decrypt_and_verify [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 9/9] smime: Index cleartext of envelopedData when requested [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Tomi Ollila—Re: Handle PKCS#7 S/MIME messages [inbox, unread]
    • Daniel Kahn Gillmor—Re: Handle PKCS#7 S/MIME messages [inbox, signed, unread]
      • Tomi Ollila—Re: Handle PKCS#7 S/MIME messages [inbox, unread]
        • David Bremner—Re: Handle PKCS#7 S/MIME messages [inbox, unread]
        • Daniel Kahn Gillmor—[PATCH 1/2] test-lib: mark function variables as local [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Daniel Kahn Gillmor—[PATCH 2/2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7 [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Tomi Ollila—Re: [PATCH 2/2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7 [inbox, unread]
            • Daniel Kahn Gillmor—[PATCH 2/2 v2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7 [inbox, notmuch::obsolete, notmuch::patch, unread]
              • David Bremner—Re: [PATCH 2/2 v2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7 [inbox, unread]
                • Daniel Kahn Gillmor—Re: [PATCH 2/2 v2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7 [inbox, signed, unread]
                • Daniel Kahn Gillmor—[PATCH 2/2 v3] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7 [inbox, notmuch::patch, notmuch::pushed, unread]
                  • David Bremner—Re: [PATCH 2/2 v3] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7 [inbox, unread]
          • Tomi Ollila—Re: [PATCH 1/2] test-lib: mark function variables as local [inbox, unread]
            • Daniel Kahn Gillmor—Re: [PATCH 1/2] test-lib: mark function variables as local [inbox, signed, unread]
          • Daniel Kahn Gillmor—[PATCH 1/2 v2] test-lib: mark function variables as local [inbox, notmuch::patch, notmuch::pushed, unread]
            • Tomi Ollila—Re: [PATCH 1/2 v2] test-lib: mark function variables as local [inbox, unread]
            • David Bremner—Re: [PATCH 1/2 v2] test-lib: mark function variables as local [inbox, unread]
              • Daniel Kahn Gillmor—Re: [PATCH 1/2 v2] test-lib: mark function variables as local [inbox, signed, unread]
                • David Bremner—Re: [PATCH 1/2 v2] test-lib: mark function variables as local [inbox, unread]
              • Daniel Kahn Gillmor—Re: [PATCH 1/2 v2] test-lib: mark function variables as local [inbox, signed, unread]