Re: [PATCH 1/2 v2] test-lib: mark function variables as local

Subject: Re: [PATCH 1/2 v2] test-lib: mark function variables as local

Date: Tue, 12 May 2020 18:14:40 -0400

To: David Bremner, Notmuch Mail

Cc: Tomi Ollila

From: Daniel Kahn Gillmor

On Sat 2020-05-09 08:47:10 -0300, David Bremner wrote:
> I'm confused about where to apply 2/2. If I apply it on top of (updated)
> master, it causes test failures. If I apply after the rest of the
> patches in this thread then presumably there is some interval where the
> build is broken (if only for certain GMime versions).

fwiw, i believe that the current master
( 627460d7bbbb6b95a07084c2b6fc7f647a5547e1 ) *is* broken on systems with
older gmime.

In particular, on debian buster, i see:

T356-protected-headers: Testing Message decryption with protected headers
 FAIL   verify signed PKCS#7 subject (multipart-signed)
	sig_uid: object not found: data[0][0][0]["crypto"]["signed"]["status"][0]["userid"]

My [PATCH v2/2 v2] in this thread (sent shortly) should resolve this
situation.  Then, i'll send a rebased version of the full S/MIME series
in a new thread.

signature.asc (application/pgp-signature)
notmuch mailing list