Re: [PATCH v2 00/20] nmbug-status: Python-3-compatibility and general refactoring

Subject: Re: [PATCH v2 00/20] nmbug-status: Python-3-compatibility and general refactoring

Date: Mon, 10 Feb 2014 22:29:35 +0200

To: W. Trevor King, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Mon, Feb 10 2014, "W. Trevor King" <wking@tremily.us> wrote:

> This is the second round of my initial series [1].  Thanks to Tomi and
> David for reviewing v1.  General changes since v1:
>
> * Python 2.6 compatibility fixes ('{0}'.format(...) and an OrderedDict
>   stub) [2].

This series looks good to me.


Tomi


>
> Changes to the HTML output since v1:
>
> * Escape &, <, and > in display data [3].
> * Changed color scheme to #ffd96e / #bce [4].
> * Added additional spacing between messages (smaller than the existing
>   spacing between threads) [5].
> * Slug section titles instead of quoting them [6].
>
> [1]: id="cover.1391424512.git.wking@tremily.us"
>      http://thread.gmane.org/gmane.mail.notmuch.general/17061
> [2]: id="20140204173914.GR19935@odin.tremily.us"
>      http://article.gmane.org/gmane.mail.notmuch.general/17114
> [3]: id="20140207221531.GA17142@odin.tremily.us"
>      http://article.gmane.org/gmane.mail.notmuch.general/17141
> [4]: id="20140208190923.GE14197@odin.tremily.us"
>      http://article.gmane.org/gmane.mail.notmuch.general/17151
> [5]: id="20140208221925.GD17142@odin.tremily.us"
>      http://article.gmane.org/gmane.mail.notmuch.general/17153
> [6]: id="20140208231804.GE17142@odin.tremily.us"
>      http://article.gmane.org/gmane.mail.notmuch.general/17155
>
> W. Trevor King (20):
>   nmbug-status: Convert to Python-3-compatible print functions
>   nmbug-status: Use email.utils instead of rfc822
>   nmbug-status: Decode Popen output using the user's locale
>   nmbug-status: Factor config-loading out into read_config
>   nmbug-status: Add metavars for --config and --get-query
>   nmbug-status: Consolidate functions and main code
>   nmbug-status: Don't require write access
>   nmbug-status: Consolidate HTML header printing
>   nmbug-status: Add a Python-3-compatible urllib.parse.quote import
>   nmbug-status: Add Page and HtmlPage for modular rendering
>   nmbug-status: Add an OrderedDict stub for Python 2.6
>   nmbug-status: Normalize table HTML indentation
>   nmbug-status: Convert from XHTML 1.0 to HTML 5
>   nmbug-status: Encode output using the user's locale
>   nmbug-status: Anchor with h3 ids instead of a names
>   nmbug-status: Slug the title when using it as an id
>   nmbug-status: Use <code> and <p> markup where appropriate
>   nmbug-status: Color threads in HTML output
>   nmbug-status: Escape &, <, and > in HTML display data
>   nmbug-status: Add inter-message padding
>
>  devel/nmbug/nmbug-status | 448 +++++++++++++++++++++++++++++++----------------
>  1 file changed, 297 insertions(+), 151 deletions(-)
>
> -- 
> 1.8.5.2.8.g0f6c0d1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: