Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale

Subject: Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale

Date: Wed, 12 Feb 2014 22:13:50 -0400

Cc: Tomi Ollila, notmuch@notmuchmail.org

"W. Trevor King" <wking@tremily.us> writes:
>
> I don't understand why your choice of LANG should depend on the
> interactive-ness of an invocation.

It's not the choice of LANG, but rather the acceptability of crashing
with an unhandled exception.

>  The upside of a configurable language is that the user gets output in
> their preferred encoding (UTF-8 or not) and—with a bit of additional
> gettext work—in their preferred language.  That sounds like a fair
> trade to me.

The downside is that it introduces another error condition into the
script. The data from notmuch is unicode; conversion to most non-utf8
locales is lossy and can cause crashes. That's why I don't like the
idea of enabling it without some explicit option or configuration
choice.

d

P.S. I just saw your other reply, and yeah, a rebased version of the
other 6 patches would be welcome.

Previous message (by thread): Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale

Thread:

W. Trevor King—[PATCH v2 00/20] nmbug-status: Python-3-compatibility and general refactoring [inbox, unread]
- W. Trevor King—[PATCH v2 01/20] nmbug-status: Convert to Python-3-compatible print functions [inbox, notmuch::patch, notmuch::portability, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 02/20] nmbug-status: Use email.utils instead of rfc822 [inbox, notmuch::patch, notmuch::portability, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 03/20] nmbug-status: Decode Popen output using the user's locale [inbox, notmuch::patch, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 04/20] nmbug-status: Factor config-loading out into read_config [inbox, notmuch::patch, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 05/20] nmbug-status: Add metavars for --config and --get-query [inbox, notmuch::doc, notmuch::patch, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 06/20] nmbug-status: Consolidate functions and main code [inbox, notmuch::patch, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 07/20] nmbug-status: Don't require write access [inbox, notmuch::patch, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 08/20] nmbug-status: Consolidate HTML header printing [inbox, notmuch::patch, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 09/20] nmbug-status: Add a Python-3-compatible urllib.parse.quote import [inbox, notmuch::patch, notmuch::portability, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 10/20] nmbug-status: Add Page and HtmlPage for modular rendering [inbox, notmuch::patch, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 11/20] nmbug-status: Add an OrderedDict stub for Python 2.6 [inbox, notmuch::patch, notmuch::portability, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 12/20] nmbug-status: Normalize table HTML indentation [inbox, notmuch::patch, notmuch::pushed, unread]
- W. Trevor King—[PATCH v2 13/20] nmbug-status: Convert from XHTML 1.0 to HTML 5 [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH v2 13/20] nmbug-status: Convert from XHTML 1.0 to HTML 5 [inbox, unread]
    - W. Trevor King—Re: [PATCH v2 13/20] nmbug-status: Convert from XHTML 1.0 to HTML 5 [inbox, signed, unread]
      - Tomi Ollila—Re: [PATCH v2 13/20] nmbug-status: Convert from XHTML 1.0 to HTML 5 [inbox, unread]
- W. Trevor King—[PATCH v2 14/20] nmbug-status: Encode output using the user's locale [inbox, notmuch::obsolete, notmuch::patch, notmuch::portability, unread]
  - David Bremner—Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale [inbox, unread]
    - Tomi Ollila—Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale [inbox, unread]
      - W. Trevor King—Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale [inbox, signed, unread]
        David Bremner—Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale [inbox, unread]
        W. Trevor King—Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale [inbox, signed, unread]
        David Bremner—Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale [inbox, unread]
        W. Trevor King—Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale [inbox, signed, unread]
        David Bremner—Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale [inbox, unread]
- W. Trevor King—[PATCH v2 15/20] nmbug-status: Anchor with h3 ids instead of a names [inbox, notmuch::fix, notmuch::obsolete, notmuch::patch, unread]
- W. Trevor King—[PATCH v2 16/20] nmbug-status: Slug the title when using it as an id [inbox, notmuch::fix, notmuch::obsolete, notmuch::patch, unread]
- W. Trevor King—[PATCH v2 17/20] nmbug-status: Use <code> and <p> markup where appropriate [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
- W. Trevor King—[PATCH v2 18/20] nmbug-status: Color threads in HTML output [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
- W. Trevor King—[PATCH v2 19/20] nmbug-status: Escape &, <, and > in HTML display data [inbox, notmuch::fix, notmuch::obsolete, notmuch::patch, unread]
- W. Trevor King—[PATCH v2 20/20] nmbug-status: Add inter-message padding [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
- Tomi Ollila—Re: [PATCH v2 00/20] nmbug-status: Python-3-compatibility and general refactoring [inbox, unread]