Re: [PATCH 01/36] test/T750-gzip: don't compress the xapian database

Subject: Re: [PATCH 01/36] test/T750-gzip: don't compress the xapian database

Date: Sun, 10 Jan 2021 17:28:54 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, Jan 03 2021, David Bremner wrote:

> This causes mysterious failures in trying to detect if a database
> exists.
> ---
>  test/T750-gzip.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/T750-gzip.sh b/test/T750-gzip.sh
> index fac41d39..807086fd 100755
> --- a/test/T750-gzip.sh
> +++ b/test/T750-gzip.sh
> @@ -171,7 +171,7 @@ test_expect_equal_file EXPECTED OUTPUT
>  add_email_corpus lkml
>  test_begin_subtest "new doesn't run out of file descriptors with many gzipped files"
>  ulimit -n 200
> -gzip --recursive ${MAIL_DIR}
> +find ${MAIL_DIR} -name .notmuch -prune -false -o  -type f  -exec gzip --recursive {} \;

(some extra spaces above)

The point of -false is that if there exists .notmuch which is file, then
include it ? (w/o -false the -o part is not included as -prune is true).

I'd suggest

find ${MAIL_DIR} -name .notmuch -prune -false -o -type f -print0 | xargs -0 gzip --

(w/o -r (no-run-if-empty) as it is gnu extension according to xargs(1) man page)





>  test_expect_success "notmuch new"
>  
>  test_done
> -- 
> 2.29.2
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: