Re: [PATCH 01/36] test/T750-gzip: don't compress the xapian database

Subject: Re: [PATCH 01/36] test/T750-gzip: don't compress the xapian database

Date: Mon, 11 Jan 2021 19:40:34 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, Jan 10 2021, David Bremner wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> On Sun, Jan 03 2021, David Bremner wrote:
>>
>>> +find ${MAIL_DIR} -name .notmuch -prune -false -o  -type f  -exec gzip --recursive {} \;
>>
>> (some extra spaces above)
>>
>> The point of -false is that if there exists .notmuch which is file, then
>> include it ? (w/o -false the -o part is not included as -prune is true).
>>
> I think the -false is just a mistake.  For some reason I thought it was
> needed to avoid descending into .notmuch
>
>> I'd suggest
>>
>> find ${MAIL_DIR} -name .notmuch -prune -false -o -type f -print0 | xargs -0 gzip --
>>
>
> what is the advantage of xargs here, less execs?

less forks and execs -- pid's don't run to very large values so soon
(it depends whether there are 3 or more files to be compressed, though :)

>
> d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: