Re: [PATCH 01/36] test/T750-gzip: don't compress the xapian database

Subject: Re: [PATCH 01/36] test/T750-gzip: don't compress the xapian database

Date: Sun, 10 Jan 2021 20:57:08 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sun, Jan 03 2021, David Bremner wrote:
>
>> +find ${MAIL_DIR} -name .notmuch -prune -false -o  -type f  -exec gzip --recursive {} \;
>
> (some extra spaces above)
>
> The point of -false is that if there exists .notmuch which is file, then
> include it ? (w/o -false the -o part is not included as -prune is true).
>
I think the -false is just a mistake.  For some reason I thought it was
needed to avoid descending into .notmuch

> I'd suggest
>
> find ${MAIL_DIR} -name .notmuch -prune -false -o -type f -print0 | xargs -0 gzip --
>

what is the advantage of xargs here, less execs?

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: