Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

Date: Thu, 08 May 2014 21:20:27 -0400

To: David Bremner, Notmuch Mail


From: Charles Celerier

David Bremner <> writes:

> Charles Celerier <> writes:
>> Here is some of output of the matches made on the output of nm:
>>     $ nm -g test/../lib/*.o | sed -n '/.*\s\+T\s\+_\(notmuch_.*\)/p'
>>     00000000000028c0 T _notmuch_database_add_message
>>     0000000000002280 T _notmuch_database_begin_atomic
>>     0000000000001af0 T _notmuch_database_close
>>     0000000000001de0 T _notmuch_database_compact
> With GNU nm, there is no leading _ in front of notmuch here, which is
> what causes your version of the test to fail for me.

What version of GNU nm are you using?

    $ nm --version
    GNU nm (GNU Binutils) 2.24
    Copyright 2013 Free Software Foundation, Inc.
    This program is free software; you may redistribute it under the terms of
    the GNU General Public License version 3 or (at your option) any later version.
    This program has absolutely no warranty.

I'm not convinced the insertion of an underscore is nm's doing.

At this point, I'm not sure how to create a better version of this
patch. Are we renaming functions in notmuch-private.h? Should we stick
with objdump or switch to using nm?

part-000.sig (application/pgp-signature)