Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

Date: Sat, 10 May 2014 18:49:24 +0900

To: Charles Celerier, Notmuch Mail

Cc:

From: David Bremner


Charles Celerier <cceleri@cs.stanford.edu> writes:

> David Bremner <david@tethera.net> writes:
>
>     $ nm --version
>     GNU nm (GNU Binutils) 2.24
>     Copyright 2013 Free Software Foundation, Inc.
>     This program is free software; you may redistribute it under the terms of
>     the GNU General Public License version 3 or (at your option) any later version.
>     This program has absolutely no warranty.
>
> I'm not convinced the insertion of an underscore is nm's doing.

OIC. right, nm is not the issue.

> At this point, I'm not sure how to create a better version of this
> patch. Are we renaming functions in notmuch-private.h? Should we stick
> with objdump or switch to using nm?

I'd go with renaming any functions that start with notmuch to start with
_notmuch.

Since it seems neither nm nor objdump provides uniform output between
OS/X and Linux, there isn't an obvious advantage to switching to nm. Any
idea if objdump can be made to work (in this test) on OS/X ?

d

Thread: