Re: [PATCH 2/5] configure, test: Added variables for paths to true and false.

Subject: Re: [PATCH 2/5] configure, test: Added variables for paths to true and false.

Date: Fri, 09 May 2014 07:14:15 +0900

To: Charles Celerier, notmuch@notmuchmail.org

Cc:

From: David Bremner


Charles Celerier <cceleri@cs.stanford.edu> writes:

> I will be the first too admit that I do not know much about configure
> scripts, but adding a TRUE variable seemed straightforward. 

configure is already big enough, I'd prefer not to add new things unless
they are needed.  This is not likely to be something the user wants to
change, and (as you note below) it's pretty easy for the the Makefile or
tests to guess.

>  You could use `$(which true)` in test/Makefile.local, but I felt the
> code repetition there was unecessary since you could just create a
> TRUE variable in the configure script.

well, it's not really code repetition because it is only used in that
one place.

> An alternative is to change the tests so that the location of true
> (and false) is no longer an issue.

Sure, that would be fine too.

d

Thread: