Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable

Subject: Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable

Date: Tue, 02 Apr 2019 00:24:16 +0300

To: Örjan Ekeberg, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sat, Mar 30 2019, Örjan Ekeberg wrote:

> These patches implement a message-send-hook which uses a buffer-local variable
> to tag replied and forwarded messages.
>
> The first patch replaces the current heuristic hook for detecting reply
> messages with an explicit setting when the reply is composed.
>
> The second patch adds the corresponding mechanism for forwarded messages.
> This patch is on top of a previously submitted patch (for adding a References
> header), and will not apply cleanly without that.

I could comprehend most of the content -- cl loop is something that would
require more learning... but I believe it works...

two things

- I wonder whether we could drop (defun notmuch-message-mark-replied ()...)
  - why is it needed for backward compatibility ?
 
- A test of a few would be nice to see how this behaves -- and we can see
  that this still works e.g. on emacs 24...

Tomi


>
> Örjan Ekeberg (2):
>   emacs: Use a buffer-local variable to update tags when sending replies
>   emacs: Tag forwarded messages with +forwarded (customizable)
>
>  emacs/notmuch-message.el | 34 ++++++++++++++++++++++++++++++++--
>  emacs/notmuch-mua.el     | 26 +++++++++++++++++++-------
>  2 files changed, 51 insertions(+), 9 deletions(-)
>
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: