Re: [PATCH v2 4/4] test: add test for checking forwarded messages

Subject: Re: [PATCH v2 4/4] test: add test for checking forwarded messages

Date: Sun, 07 Apr 2019 22:24:40 +0200

To: Tomi Ollila,


From: Örjan Ekeberg

Tomi Ollila <> writes:

> On Fri, Apr 05 2019, Örjan Ekeberg wrote:
>> +test_begin_subtest "Forward setting the correct references header"
>> +message_id=''
>> +add_message \
>> +    [id]="$message_id" \
>> +    '[from]=""' \
>> +    '[subject]="This is the original message"' \
>> +    '[body]="-----Original Message-----
>> +Text here."'
>> +
>> +test_emacs "(let ((message-hidden-headers ())
>> +	          (notmuch-fcc-dirs ()))
>> +	     (notmuch-show \"id:$message_id\")
>> +	     (notmuch-show-forward-message)
>> +             (run-hooks 'notmuch-mua-send-hook)
>> +	     (message-narrow-to-headers)
>> +	     (test-visible-output))
>> +            (run-hooks 'notmuch-mua-send-hook)"
> Cannot fully understand the above (or, actually not much of it), perhaps
> someone else(tm).

Short walkthrough:
  - create a small message in the database (add_message)
  - set message-hidden-headers to nil so that we can verify them
  - set notmuch-fcc-dirs to nil to avoid including the fcc-header
  - get the message we just created (notmuch-show)
  - create a forwarding message (forwarding the current one)
  - compare the headers to the expected output
  - run the send hooks to emulate sending

The double run-hooks lines is an error; only the second one is needed.

> anyway, it looks like tabs and 8-spaces are used for indenting.

Yes.  This seems to be common in the emacs code for notmuch, so I did
not untabify.

> then, instead of only checking forwarded tag was added, checking
> checking all tags should be done, so that there is nothing extra
> (that check twice, first after add_message, and then at the end)

The test was only supposed to check that the forwarded tag was properly
added when forwarding.  If other tags are added elsewhere in future
code, this is not really an error and should not be flagged by the test,
should it?

> Tomi

Thanks for your feedback.

notmuch mailing list