Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

Subject: Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

Date: Mon, 30 Jan 2012 09:37:17 +0000

To: Jameson Graef Rollins, notmuch@notmuchmail.org

Cc:

From: David Edmondson


On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > My inclination is to remove `notmuch-crypto-process-mime' altogether
> > (declared it an obsolete variable) and allow users to set a default
> > for `notmuch-show-process-crypto' directly, but that is not done in
> > this patchset while awaiting feedback.
> 
> I'm not sure I understand this.  `notmuch-show-process-crypto' *is* what
> sets the default for the `notmuch-show-process-crypto' buffer-local
> variable.  How would you change the current behavior or settings (beyond
> just a variable rename)?

The problem with the code as I posted can be seen if you imagine the
following ~/.emacs.el sequence:

part-000.bin (application/emacs-lisp)
I'm sure that I can figure out either some `defcustom' goop or worse to
sort it out so that the initialisation happens correctly.

> > `notmuch-crypto-process-mime' is used only in notmuch-show.el, so the
> > setting really belongs there with an appropriate name.
> 
> I intentionally put this in a separate section in case there were
> eventually other needs for this setting beyond just show mode.  I
> personally think we should just leave it where it is, particularly
> since it's been there for a while.

Okay.
part-001.sig (application/pgp-signature)

Thread: