Re: [PATCH v8 0/8] reworked crypto toggle, plus a few other toggles

Subject: Re: [PATCH v8 0/8] reworked crypto toggle, plus a few other toggles

Date: Mon, 15 Oct 2012 18:17:09 -0400

To: Pieter Praet, David Edmondson

Cc: Notmuch Mail

From: Ethan Glasser-Camp

Pieter Praet <pieter@praet.org> writes:

> Great work!
>
> Here's some tests.

Hi! These look fine to me. With Mark's review
(id:"87k41e45hi.fsf@qmul.ac.uk"), I'm removing the needs-review tag.

Ethan

• Previous message (by thread): Re: [PATCH] test: Move tests from emacs to emacs-show

Thread:

• David Edmondson—[PATCH 0/3] reworked crypto toggle, plus a couple of other toggles [inbox, unread]
  • David Edmondson—[PATCH 1/3] emacs: Rework crypto switch toggle. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—[PATCH 2/3] emacs: Allow `notmuch-show-mode' to display only matching messages. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—[PATCH 3/3] emacs: Allow the indentation of content to be toggled. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Mark Walters—Re: [PATCH 3/3] emacs: Allow the indentation of content to be toggled. [inbox, notmuch::review, unread]
      • David Edmondson—Re: [PATCH 3/3] emacs: Allow the indentation of content to be toggled. [inbox, signed, unread]
      • David Edmondson—Re: [PATCH 3/3] emacs: Allow the indentation of content to be toggled. [inbox, signed, unread]
  • Jameson Graef Rollins—Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles [inbox, notmuch::review, signed, unread]
    • David Edmondson—Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles [inbox, signed, unread]
      • David Edmondson—Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles [inbox, signed, unread]
        • Jameson Graef Rollins—Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles [inbox, signed, unread]
  • David Edmondson—[PATCH 0/3 v2] reworked crypto toggle, plus a couple of other toggles [inbox, unread]
    • David Edmondson—[PATCH 1/3 v2] emacs: Rework crypto switch toggle. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH 2/3 v2] emacs: Allow `notmuch-show-mode' to display only matching messages. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH 3/3 v2] emacs: Allow the indentation of content to be toggled. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—[PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles [inbox, unread]
    • David Edmondson—[PATCH 1/5] emacs: Rework crypto switch toggle. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH 3/5] emacs: Allow the indentation of content to be toggled. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jani Nikula—Re: [PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines. [inbox, unread]
        • David Edmondson—Re: [PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines. [inbox, signed, unread]
    • David Edmondson—[PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Mark Walters—Re: [PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'. [inbox, unread]
        • David Edmondson—Re: [PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'. [inbox, signed, unread]
    • Tomi Ollila—Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles [inbox, unread]
    • Jameson Graef Rollins—Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles [inbox, signed, unread]
      • David Edmondson—Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles [inbox, signed, unread]
        • Jameson Graef Rollins—Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles [inbox, signed, unread]
          • David Edmondson—Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles [inbox, signed, unread]
  • David Edmondson—[PATCH v5 0/6] reworked crypto toggle, plus a few other toggles [inbox, unread]
    • David Edmondson—[PATCH v5 1/6] emacs: Rework crypto switch toggle. [inbox, unread]
    • David Edmondson—[PATCH v5 2/6] emacs: Allow `notmuch-show-mode' to display only matching messages. [inbox, unread]
    • David Edmondson—[PATCH v5 3/6] emacs: Allow the indentation of content to be toggled. [inbox, unread]
    • David Edmondson—[PATCH v5 4/6] emacs: Add a binding (t) to toggle the truncation of long lines. [inbox, unread]
    • David Edmondson—[PATCH v5 5/6] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'. [inbox, unread]
    • David Edmondson—[PATCH v5 6/6] emacs: Check that the parent buffer is alive before using it. [inbox, unread]
  • David Edmondson—[PATCH v6 0/8] reworked crypto toggle, plus a few other toggles [inbox, unread]
    • David Edmondson—[PATCH v6 1/8] emacs: Rework crypto switch toggle. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Edmondson—Re: [PATCH v6 1/8] emacs: Rework crypto switch toggle. [inbox, signed, unread]
    • David Edmondson—[PATCH v6 2/8] emacs: Allow `notmuch-show-mode' to display only matching messages. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v6 3/8] emacs: Allow the indentation of content to be toggled. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v6 4/8] emacs: Add a binding (t) to toggle the truncation of long lines. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v6 5/8] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v6 6/8] emacs: Check that the parent buffer is alive before using it. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v6 7/8] emacs: Add `notmuch-show-only-matching-messages'. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v6 8/8] emacs: A prefix argument to `notmuch-show' should invert the matching message behaviour. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—[PATCH v7 0/8] reworked crypto toggle, plus a few other toggles [inbox, unread]
    • David Edmondson—[PATCH v7 1/8] emacs: Rework crypto switch toggle. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Austin Clements—Re: [PATCH v7 1/8] emacs: Rework crypto switch toggle. [inbox, notmuch::review, unread]
        • David Edmondson—Re: [PATCH v7 1/8] emacs: Rework crypto switch toggle. [inbox, signed, unread]
    • David Edmondson—[PATCH v7 2/8] emacs: Allow `notmuch-show-mode' to display only matching messages. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v7 3/8] emacs: Allow the indentation of content to be toggled. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v7 4/8] emacs: Add a binding (t) to toggle the truncation of long lines. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v7 5/8] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v7 6/8] emacs: Check that the parent buffer is alive before using it. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v7 7/8] emacs: Add `notmuch-show-only-matching-messages'. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—[PATCH v7 8/8] emacs: A prefix argument to `notmuch-show' should invert the matching message behaviour. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH v7 0/8] reworked crypto toggle, plus a few other toggles [inbox, notmuch::review, unread]
  • David Edmondson—[PATCH v8 0/8] reworked crypto toggle, plus a few other toggles [inbox, unread]
    • David Edmondson—[PATCH v8 1/8] emacs: Rework crypto switch toggle. [inbox, notmuch::patch, notmuch::pushed, unread]
      • Austin Clements—Re: [PATCH v8 1/8] emacs: Rework crypto switch toggle. [inbox, notmuch::review, unread]
    • David Edmondson—[PATCH v3 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'. [inbox, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
      • David Bremner—Re: [PATCH v3 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'. [inbox, unread]
    • David Edmondson—[PATCH v8 2/8] emacs: Allow `notmuch-show-mode' to display only matching messages. [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Edmondson—[PATCH v3 2/2] test: Update test to match previous patch. [inbox, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
      • Ethan Glasser-Camp—Re: [PATCH v3 2/2] test: Update test to match previous patch. [inbox, notmuch::review, unread]
        • Jameson Graef Rollins—Re: [PATCH v3 2/2] test: Update test to match previous patch. [inbox, signed, unread]
    • David Edmondson—[PATCH v8 3/8] emacs: Allow the indentation of content to be toggled. [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Edmondson—[PATCH v8 4/8] emacs: Add a binding (t) to toggle the truncation of long lines. [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Edmondson—[PATCH v8 5/8] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'. [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Edmondson—[PATCH v8 6/8] emacs: Check that the parent buffer is alive before using it. [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Edmondson—[PATCH v8 7/8] emacs: Add `notmuch-show-only-matching-messages'. [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Edmondson—[PATCH v8 8/8] emacs: A prefix argument to `notmuch-show' should invert the matching message behaviour. [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Edmondson—Re: [PATCH v8 0/8] reworked crypto toggle, plus a few other toggles [inbox, signed, unread]
    • David Bremner—Re: [PATCH v8 0/8] reworked crypto toggle, plus a few other toggles [inbox, unread]
    • Pieter Praet—Re: [PATCH v8 0/8] reworked crypto toggle, plus a few other toggles [inbox, notmuch::review, unread]
      • Pieter Praet—[PATCH 1/3] test: emacs: toggle processing of cryptographic MIME parts in `notmuch-show' [inbox, notmuch::patch, notmuch::stale, notmuch::test, unread]
        • Ethan Glasser-Camp—[PATCH 1/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show' [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
          • Ethan Glasser-Camp—[PATCH] test: Move tests from emacs to emacs-show [inbox, notmuch::patch, notmuch::pushed, unread]
            • Tomi Ollila—Re: [PATCH] test: Move tests from emacs to emacs-show [inbox, unread]
            • David Bremner—Re: [PATCH] test: Move tests from emacs to emacs-show [inbox, unread]
      • Pieter Praet—[PATCH 2/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show' [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
        • Mark Walters—Re: [PATCH 2/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show' [inbox, notmuch::review, unread]
      • Pieter Praet—[PATCH 3/3] test: emacs: toggle thread content indentation in `notmuch-show' [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
      • Ethan Glasser-Camp—Re: [PATCH v8 0/8] reworked crypto toggle, plus a few other toggles [inbox, unread]
        • David Bremner—Re: [PATCH v8 0/8] reworked crypto toggle, plus a few other toggles [inbox, unread]