Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

Subject: Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

Date: Mon, 30 Jan 2012 09:47:34 -0800

To: David Edmondson,


From: Jameson Graef Rollins

On Mon, 30 Jan 2012 16:30:59 +0000, David Edmondson <> wrote:
> v3:
>  - Add a toggle for line truncation (>).
>  - Retain the state of a show buffer across a call to refresh (which
>    includes the various toggles here).
> David Edmondson (5):
>   emacs: Rework crypto switch toggle.
>   emacs: Allow `notmuch-show-mode' to display only matching messages.
>   emacs: Allow the indentation of content to be toggled.
>   emacs: Add a binding (>) to toggle the truncation of long lines.
>   emacs: Retain the state of the buffer during
>     `notmuch-show-refresh-view'.
>  emacs/notmuch-show.el |  183 +++++++++++++++++++++++++++++++++----------------
>  emacs/notmuch.el      |    7 +-
>  2 files changed, 126 insertions(+), 64 deletions(-)

Still testing, but so far works great.  Again, this is 

One thing I've noticed, which isn't actually part of this patch, is that
the long-line truncation doesn't respect the indentation, which makes
things look strange.

But honestly I still don't like our method of displaying threads as a
giant chain of concatenated messages with indentation.  But that's for
later work.

Again, I haven't done a code review yet, but so far this seems to work
like a charm.

part-000.sig (application/pgp-signature)