Re: [PATCH 6/8] cli: add support for batch tagging operations to "notmuch tag"

Subject: Re: [PATCH 6/8] cli: add support for batch tagging operations to "notmuch tag"

Date: Tue, 3 Apr 2012 00:31:53 +0300

To: Jameson Graef Rollins

Cc: Notmuch Mail

From: Jani Nikula


On Apr 3, 2012 12:20 AM, "Jameson Graef Rollins" <jrollins@finestructure.net>
wrote:
>
> On Mon, Apr 02 2012, Jani Nikula <jani@nikula.org> wrote:
> > Batch tagging brings performance and atomicity by opening and closing
the
> > db only once. The hex encoding handles insane message ids and tags.
> > Otherwise there should be no difference.
>
> I can maybe see performance in terms of opening and closing the db only
> once, but atomicity?  Not sure I see how that is improved.

Err, I meant locking, sorry. Nobody else is able to alter the db while
batch tagging is in progress.

>
> And shouldn't we be able to improve the handling of command line
> arguments so that we get the same encoding handling on the command line
> as we would from stdin?
>
> jamie.

Thread: