Re: [PATCH 2/8] hex-escape: be more strict about the format while decoding

Subject: Re: [PATCH 2/8] hex-escape: be more strict about the format while decoding

Date: Thu, 05 Apr 2012 08:33:23 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jani Nikula <jani@nikula.org> writes:

> Signed-off-by: Jani Nikula <jani@nikula.org>
>
> ---
>
> This could be folded to "hex-escape: (en|de)code strings to/from
> restricted character set".

That's probably a good plan.

> -	    if (len < 3)
> +	    if (!isxdigit ((unsigned char) p[1]) ||
> +		!isxdigit ((unsigned char) p[2]))

What happens if there are not two characters after the escape? Is this
relying on calling isxdigit on the null terminator?

d

Thread: