Re: [PATCH 6/8] cli: add support for batch tagging operations to "notmuch tag"

Subject: Re: [PATCH 6/8] cli: add support for batch tagging operations to "notmuch tag"

Date: Tue, 03 Apr 2012 23:09:47 -0300

To: Jameson Graef Rollins, Jani Nikula

Cc: Notmuch Mail

From: David Bremner


Jameson Graef Rollins <jrollins@finestructure.net> writes:

> There's no point in adding and initial flag to the beginning of the
> line to specify the command to execute if you have no intention of
> ever supporting other commands. 

My thinking was that it was useful for the disk format to have a bit
more information in it so that we could more easily change the interface
in an upwardly compatible way. If at some point in the future we do have
more general batch command processing, it would be nice not have to
change the file format again, particularly for dump files.

> Ultimately, I think this patch series suffers from being
> simultaneously too close to existing functionality (restore),

Well, as Jani mentioned there is a fair amount of code overlap with an
in-progress improved dump/restore facility.

> yet tantalizingly close to a much more generally useful concept of
> batch command processing.

Well, opinions seem to differ about how close we are to that in terms of
real code, but I think it is worth thinking about as we define file
formats.

d


Thread: