Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

Subject: Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

Date: Sun, 8 May 2011 18:02:00 -0400

To: Florian Friesdorf

Cc: notmuch@notmuchmail.org, Andreas Amann

From: Austin Clements

On Sun, May 8, 2011 at 5:54 PM, Florian Friesdorf <flo@chaoflow.net> wrote:
> On Sun, 8 May 2011 17:40:54 -0400, Austin Clements <amdragon@mit.edu> wrote:
>> Also, existing code conventionally uses a variable named "local"
>> for function-level talloc contexts such as your ctx_quote.
>
> In notmuch-search.c there is no variable named "local", in the other
> functions its also named ctx_quote. Should I rename all ctx_quote to
> "local"?

Huh, sure enough.  Looks like the library uses "local" consistently,
but the CLI uses ctx_quote multiple times and "local" appears only
once, so, yeah, stick with ctx_quote.

• Previous message (by thread): Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

Thread:

• Florian Friesdorf—[PATCH] search --format=sanitized_text [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Florian Friesdorf—[PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Austin Clements—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, unread]
      • Florian Friesdorf—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, signed, unread]
      • Jameson Graef Rollins—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, signed, unread]
        • Pieter Praet—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, unread]
          • Pieter Praet—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, unread]
        • Florian Friesdorf—[PATCH] sanitize notmuch-search output - rewrapped [inbox, unread]
          • Florian Friesdorf—[PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, notmuch::patch, notmuch::stale, unread]
            • Austin Clements—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, unread]
              • Florian Friesdorf—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, signed, unread]
                • Austin Clements—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, unread]
                  • Florian Friesdorf—[PATCH] sanitize notmuch-search output - rewrapped [inbox, unread]
                    • Florian Friesdorf—Re: [PATCH] sanitize notmuch-search output - rewrapped [inbox, signed, unread]
                  • Florian Friesdorf—[PATCH 1/2] style fixes [inbox, notmuch::patch, notmuch::stale, unread]
                    • Florian Friesdorf—[PATCH 2/2] test for sanitized notmuch-search output [inbox, notmuch::patch, notmuch::stale, unread]
            • Jameson Graef Rollins—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, signed, unread]