Re: [PATCH] implement search --format=sanitized

Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it

Subject: Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it

Date: Fri, 06 May 2011 18:06:47 -0700

To: Austin Clements, Florian Friesdorf

Cc: notmuch@notmuchmail.org, a.amann@ucc.ie

On Fri, 6 May 2011 19:55:26 -0400, Austin Clements <amdragon@mit.edu> wrote:
> Perhaps text summary output should *always* do this.  The text summary
> format is meant half for user consumption and half for emacs
> consumption and allowing newlines that don't indicate the end of a
> summary line seems bad for *both* use cases.

Hi, Florian.  I think I agree with Austin here that the text output
should probably just always be sanitized.  Can you try sending in a
patch that just automatically sanitizes the text output?

Also, I believe that this patch is not entirely compatible with the
current head of the release-candidate/0.6 branch.  I pushed a patch to
that branch to fix a search output formatting bug, and in so doing I
added a field to the search_format struct.

If you could make those changes and post a new patch that would be
great.  Thanks.

jamie.

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

Thread:

Florian Friesdorf—[PATCH] search --format=sanitized_text [inbox, notmuch::obsolete, notmuch::patch, unread]
- Florian Friesdorf—[PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, unread]
    - Florian Friesdorf—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, signed, unread]
    - Jameson Graef Rollins—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, signed, unread]
      - Pieter Praet—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, unread]
        Pieter Praet—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, unread]
      - Florian Friesdorf—[PATCH] sanitize notmuch-search output - rewrapped [inbox, unread]
        Florian Friesdorf—[PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, notmuch::patch, notmuch::stale, unread]
        Austin Clements—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, unread]
        Florian Friesdorf—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, signed, unread]
        Austin Clements—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, unread]
        Florian Friesdorf—[PATCH] sanitize notmuch-search output - rewrapped [inbox, unread]
        Florian Friesdorf—Re: [PATCH] sanitize notmuch-search output - rewrapped [inbox, signed, unread]
        Florian Friesdorf—[PATCH 1/2] style fixes [inbox, notmuch::patch, notmuch::stale, unread]
        Florian Friesdorf—[PATCH 2/2] test for sanitized notmuch-search output [inbox, notmuch::patch, notmuch::stale, unread]
        Jameson Graef Rollins—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, signed, unread]