Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

Subject: Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

Date: Sun, 08 May 2011 23:54:17 +0200

Cc: notmuch@notmuchmail.org, Andreas Amann

On Sun, 8 May 2011 17:40:54 -0400, Austin Clements <amdragon@mit.edu> wrote:
> Cool.  This seems very reasonable.
> 
> Just some style nits: The three places where you have
> "sanitize_string(", there should be a space between the function name
> and the paren.

fixed

> Relatedly, "for(;*loop;loop++){" should be spaced out
> like "for (; *loop; loop++) {".

fixed

> (..) 
> Also, existing code conventionally uses a variable named "local"
> for function-level talloc contexts such as your ctx_quote.

In notmuch-search.c there is no variable named "local", in the other
functions its also named ctx_quote. Should I rename all ctx_quote to
"local"?

Will send style fixes after we cleared this.

-- 
Florian Friesdorf <flo@chaoflow.net>
  GPG FPR: 7A13 5EEE 1421 9FC2 108D  BAAF 38F8 99A3 0C45 F083
Jabber/XMPP: flo@chaoflow.net
IRC: chaoflow on freenode,ircnet,blafasel,OFTC

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

Thread:

Florian Friesdorf—[PATCH] search --format=sanitized_text [inbox, notmuch::obsolete, notmuch::patch, unread]
- Florian Friesdorf—[PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, unread]
    - Florian Friesdorf—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, signed, unread]
    - Jameson Graef Rollins—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, signed, unread]
      - Pieter Praet—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, unread]
        Pieter Praet—Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it [inbox, unread]
      - Florian Friesdorf—[PATCH] sanitize notmuch-search output - rewrapped [inbox, unread]
        Florian Friesdorf—[PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, notmuch::patch, notmuch::stale, unread]
        Austin Clements—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, unread]
        Florian Friesdorf—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, signed, unread]
        Austin Clements—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, unread]
        Florian Friesdorf—[PATCH] sanitize notmuch-search output - rewrapped [inbox, unread]
        Florian Friesdorf—Re: [PATCH] sanitize notmuch-search output - rewrapped [inbox, signed, unread]
        Florian Friesdorf—[PATCH 1/2] style fixes [inbox, notmuch::patch, notmuch::stale, unread]
        Florian Friesdorf—[PATCH 2/2] test for sanitized notmuch-search output [inbox, notmuch::patch, notmuch::stale, unread]
        Jameson Graef Rollins—Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, signed, unread]