Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

Date: Thu, 02 Feb 2012 10:00:59 -0800

To: Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins

Hey, Dmitry.  I'm so sorry I sent my last email on your original patch
before I saw this new series.  I do now like your original proposal
better, since it shows the diff based the names the caller provides,
which I now agree is probably the clearest and most robust solution.
The second patch in this series could still go through, though, no
matter what version of the change to test_expect_equal_file we go with.

jamie.

• Previous message (by thread): Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

Thread:

• Dmitry Kurochkin—[PATCH 0/2] test_expect_equal_file arguments check [inbox, unread]
  • Dmitry Kurochkin—[PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, signed, unread]
      • Dmitry Kurochkin—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
      • Dmitry Kurochkin—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, signed, unread]
        • Tomi Ollila—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
        • Ethan Glasser-Camp—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
          • Tomi Ollila—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
  • Dmitry Kurochkin—[PATCH 2/2] test: fix order and format of test_expect_equal_file arguments [inbox, notmuch::patch, notmuch::stale, unread]