Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

Date: Fri, 03 Feb 2012 13:24:53 -0800

To: Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins

On Fri, 03 Feb 2012 18:04:05 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Actually, we can do both: check file name for consistent diff order
> (from expected to actual) and use file names that the caller provides.
> 
> What do you think?

I'm not sure it's worth it, but I suppose that's fine.

jamie.

• Previous message (by thread): Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

Thread:

• Dmitry Kurochkin—[PATCH 0/2] test_expect_equal_file arguments check [inbox, unread]
  • Dmitry Kurochkin—[PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, signed, unread]
      • Dmitry Kurochkin—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
      • Dmitry Kurochkin—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, signed, unread]
        • Tomi Ollila—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
        • Ethan Glasser-Camp—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
          • Tomi Ollila—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
  • Dmitry Kurochkin—[PATCH 2/2] test: fix order and format of test_expect_equal_file arguments [inbox, notmuch::patch, notmuch::stale, unread]