Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

Date: Fri, 12 Oct 2012 13:42:24 -0400

To: Dmitry Kurochkin, Jameson Graef Rollins, notmuch@notmuchmail.org

Cc:

From: Ethan Glasser-Camp

Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:

> Actually, we can do both: check file name for consistent diff order
> (from expected to actual) and use file names that the caller provides.

Hi! Reviewing the patch queue a little bit here. It seems like this
patch ended up getting dropped because the other approach (using the
filenames that the caller provided) won out and was even pushed. I'm
therefore marking this series notmuch::obsolete (and also
notmuch::stale since it doesn't apply cleanly).

Ethan

• Previous message (by thread): Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

Thread:

• Dmitry Kurochkin—[PATCH 0/2] test_expect_equal_file arguments check [inbox, unread]
  • Dmitry Kurochkin—[PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, signed, unread]
      • Dmitry Kurochkin—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
      • Dmitry Kurochkin—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, signed, unread]
        • Tomi Ollila—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
        • Ethan Glasser-Camp—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
          • Tomi Ollila—Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file [inbox, unread]
  • Dmitry Kurochkin—[PATCH 2/2] test: fix order and format of test_expect_equal_file arguments [inbox, notmuch::patch, notmuch::stale, unread]