Re: [PATCH 3/3] notmuch-show: detect xapian exception in query

Subject: Re: [PATCH 3/3] notmuch-show: detect xapian exception in query

Date: Fri, 24 Jan 2014 20:41:57 -0400

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jani Nikula <jani@nikula.org> writes:
>
> This should just return 1 or something. See how the function eventually
> returns res != NOTMUCH_STATUS_SUCCESS instead of notmuch_status_t. And
> threads == NULL is not guaranteed to mean an exception occurred anyway.
>
> Otherwise the patch LGTM, and is in line with the error handling in
> notmuch search, which does not segfault on similar queries.

pushed a version amended as suggested.

d

• Previous message (by thread): Re: segfault if notmuch-show query has spurious .. (w/ v0.17)

Thread:

• Sanjoy Mahajan—segfault if notmuch-show query has spurious .. (w/ v0.17) [inbox, notmuch::bug, notmuch::fixed, unread]
  • David Bremner—Re: segfault if notmuch-show query has spurious .. (w/ v0.17) [inbox, unread]
    • David Bremner—[PATCH] lib: make notmuch_threads_valid return FALSE when passed NULL [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Tomi Ollila—Re: [PATCH] lib: make notmuch_threads_valid return FALSE when passed NULL [inbox, notmuch::review, unread]
        • David Bremner—Round 2: fix for notmuch show segfault [inbox, unread]
          • David Bremner—[PATCH 1/3] test: add known broken test exit code of notmuch show [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
          • David Bremner—[PATCH 2/3] lib: make notmuch_threads_valid return FALSE when passed NULL [inbox, notmuch::patch, notmuch::pushed, unread]
            • Jani Nikula—Re: [PATCH 2/3] lib: make notmuch_threads_valid return FALSE when passed NULL [inbox, unread]
          • David Bremner—[PATCH 3/3] notmuch-show: detect xapian exception in query [inbox, notmuch::obsolete, notmuch::patch, notmuch::pushed, unread]
            • Jani Nikula—Re: [PATCH 3/3] notmuch-show: detect xapian exception in query [inbox, unread]
              • David Bremner—Re: [PATCH 3/3] notmuch-show: detect xapian exception in query [inbox, unread]
          • Mark Walters—Re: Round 2: fix for notmuch show segfault [inbox, unread]
            • Tomi Ollila—Re: Round 2: fix for notmuch show segfault [inbox, unread]
  • David Bremner—Re: segfault if notmuch-show query has spurious .. (w/ v0.17) [inbox, unread]