Re: [PATCH v4] emacs: customizable names for search buffers

Subject:Re: [PATCH v4] emacs: customizable names for search buffers

Date:Sun, 16 Jan 2022 22:25:06 +0000

To:Kyle Meyer

Cc:notmuch@notmuchmail.org

From:Jose A Ortega Ruiz


On Sun, Jan 16 2022, Kyle Meyer wrote:

> Jose A Ortega Ruiz writes:
>
>> yeah, that's what i use and didn't notice my error above.  format-spec
>> is much nicer than a plain regexp subs, one can use format specifiers
>> like %3t and many others, but unfortunately seems to have been
>> introduced in emacs 27.
>
> format-spec has been present in Emacs since version 21.1, specifically
> c113de23613 (2000-09-19).  (Some parameters have been added since then,
> but you only use FORMAT and SPECIFICATION in your patch.)
>
> Here's a test with Emacs 25, Notmuch's current minimum (if I grep
> correctly):
>
>   (emacs-version) ; => "GNU Emacs 25.3.50.1 ..."
>   (require 'format-spec)
>   (format-spec "%b" '((?b . "fine"))) ; => "fine"
>
> At first I thought you were getting confused by the fact that
> format-spec has been marked as autoloaded only recently, but it looks
> like that was in 0185d76e742 (Fix and extend format-spec (bug#41758),
> 2020-06-18), which will be part of the 28.1 release.  So that's not
> consistent with "introduced in emacs 27".

In very recent emacs (i'm using its master branch, actually), if one M-x
describe-function RET format-spec one sees in the help buffer:

     Probably introduced at or before Emacs version 27.1.

that's where my misconception came from.  

I guess that's potentially good news: i don't see an emacs version
specified in notmuch's package: is it supposed to be compatible with
emacs < 25.3?  If not, we can just forget about the regexp branch.

Thanks a lot for checking,
jao
-- 
"The evil that is in the world almost always comes of ignorance, and
good intentions may do as much harm as malevolence if they lack understanding."
 - Albert Camus
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: