Re: [PATCH v2 2/6] test: more style fixes

Subject: Re: [PATCH v2 2/6] test: more style fixes

Date: Sun, 16 May 2021 09:08:36 -0300

To: Felipe Contreras,


From: David Bremner

Felipe Contreras <> writes:

> In order to fit the git coding style.
> Signed-off-by: Felipe Contreras <>

I personally prefer this style, but I have to point out that the C and
C++ code in the code base (including the Ruby bindings) use the
"brace-on-the-next-line" style. Should we strive for consistency with
the C code, or is there some overriding concern here? Tomi mentioned
compactness; is that more important for shell scripts? Whatever we
decide, I guess it should be documented in test/README. For the record,
I don't think restyling the rest of the codebase to match is a good
notmuch mailing list --
To unsubscribe send an email to